qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 16:00:06 -07:00
Code Releases Activity

fmt: add a few more reflect.Value tests

Browse Source 
Change-Id: I86530a4fd240f3e056e3277355d2965f6863b852
Reviewed-on: https://go-review.googlesource.com/8951
Reviewed-by: Rob Pike <r@golang.org>
This commit is contained in:
Russ Cox 2015-04-15 13:49:32 -04:00
parent 6b045d9aef
commit 3e6b7f35de
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/fmt/fmt_test.go
View File

@ -686,6 +686,14 @@ var fmtTests = []struct {
// Issue 8965. // Issue 8965.
{"%v", reflect.ValueOf(A{}).Field(0).String(), "<int Value>"}, // Equivalent to the old way. {"%v", reflect.ValueOf(A{}).Field(0).String(), "<int Value>"}, // Equivalent to the old way.
{"%v", reflect.ValueOf(A{}).Field(0), "0"}, // Sees inside the field. {"%v", reflect.ValueOf(A{}).Field(0), "0"}, // Sees inside the field.
// verbs apply to the extracted value too.
{"%s", reflect.ValueOf("hello"), "hello"},
{"%q", reflect.ValueOf("hello"), `"hello"`},
{"%#04x", reflect.ValueOf(256), "0x0100"},
// invalid reflect.Value doesn't crash.
{"%v", reflect.Value{}, "<nil>"},
} }
// zeroFill generates zero-filled strings of the specified width. The length // zeroFill generates zero-filled strings of the specified width. The length

2
src/fmt/print.go
View File

@ -847,6 +847,8 @@ func (p *pp) printReflectValue(value reflect.Value, verb rune, depth int) (wasSt
p.value = value p.value = value
BigSwitch: BigSwitch:
switch f := value; f.Kind() { switch f := value; f.Kind() {
case reflect.Invalid:
p.buf.WriteString("<invalid reflect.Value>")
case reflect.Bool: case reflect.Bool:
p.fmtBool(f.Bool(), verb) p.fmtBool(f.Bool(), verb)
case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64: case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64: