qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 16:04:48 -07:00
Code Releases Activity

cmd/trace: include P info in goroutine slices

Browse Source 
The task-oriented trace view presents the execution trace organized
based on goroutines. Often, which P a goroutine was running on is
useful, so this CL includes the P ids in the goroutine execution slices.

R=go1.11

Change-Id: I96539bf8215e5c1cd8cc997a90204f57347c48c8
Reviewed-on: https://go-review.googlesource.com/90221
Reviewed-by: Heschi Kreinick <heschi@google.com>
This commit is contained in:
Hana Kim 2018-01-26 10:28:10 -05:00 committed by Hyang-Ah Hana Kim
parent f42418b25d
commit 3e1ac1b017
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/cmd/trace/trace.go
View File

@ -726,8 +726,17 @@ func (ctx *traceContext) emitSlice(ev *trace.Event, name string) *ViewerEvent {
Stack: ctx.stack(ev.Stk), Stack: ctx.stack(ev.Stk),
EndStack: ctx.stack(ev.Link.Stk), EndStack: ctx.stack(ev.Link.Stk),
} }
// grey out non-overlapping events if the event is not a global event (ev.G == 0) // grey out non-overlapping events if the event is not a global event (ev.G == 0)
if ctx.mode == taskTraceview && ev.G != 0 { if ctx.mode == taskTraceview && ev.G != 0 {
// include P information.
if t := ev.Type; t == trace.EvGoStart || t == trace.EvGoStartLabel {
type Arg struct {
P int
}
sl.Arg = &Arg{P: ev.P}
}
// grey out non-overlapping events.
overlapping := false overlapping := false
for _, task := range ctx.tasks { for _, task := range ctx.tasks {
if _, overlapped := task.overlappingDuration(ev); overlapped { if _, overlapped := task.overlappingDuration(ev); overlapped {