qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 08:47:56 -07:00
Code Releases Activity

test: adjust bug324 to expect run-time failure, not compile-time.

Browse Source 
Failing at compile time requires that for each conversion
between two interface types the compiler compare the sets of
unexported methods to see if they come from different
packages.  Since this test will fail approximately never on
real code, and since it can't catch all cases of the problem,
I don't think it's worth testing in the compiler.  This CL
changes this test to look for a run-time panic rather than a
compile-time error.

R=gri, rsc1, iant2, rsc
CC=golang-dev
https://golang.org/cl/4332041
This commit is contained in:
Ian Lance Taylor 2011-03-29 15:03:09 -07:00
parent 974d2c98e0
commit 3dbf65871c
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/bugs/bug324.dir/main.go
View File

@ -40,7 +40,7 @@ func main() {
// x = px // x = px
// this assignment unexpectedly compiles and then executes // this assignment unexpectedly compiles and then executes
x = px.(Exported) // ERROR "does not implement" x = px.(Exported)
// this is a legitimate call, but because of the previous assignment, // this is a legitimate call, but because of the previous assignment,
// it invokes the method private in p! // it invokes the method private in p!

2
test/bugs/bug324.go
View File

@ -1,4 +1,4 @@
// $G $D/$F.dir/p.go && errchk $G $D/$F.dir/main.go // $G $D/$F.dir/p.go && $G $D/$F.dir/main.go && $L main.$A && ! ./$A.out || echo BUG: should fail
// Copyright 2011 The Go Authors. All rights reserved. // Copyright 2011 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style // Use of this source code is governed by a BSD-style

4
test/golden.out
View File

@ -165,4 +165,6 @@ bugs/bug322.dir/main.go:32: implicit assignment of unexported field 'x' of lib.T
BUG: fails incorrectly BUG: fails incorrectly
=========== bugs/bug324.go =========== bugs/bug324.go
BUG: errchk: command succeeded unexpectedly main.Implementation.private()
p.Implementation.private()
BUG: should fail