From 3d2e75cf922440870596e9bc6145630b2b6a3d5d Mon Sep 17 00:00:00 2001 From: Dmitriy Vyukov Date: Mon, 16 Jan 2012 11:11:58 +0400 Subject: [PATCH] exp/inotify: fix data race in linux tests Fixes #2708. R=golang-dev, bradfitz CC=golang-dev, mpimenov https://golang.org/cl/5543060 --- src/pkg/exp/inotify/inotify_linux_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/pkg/exp/inotify/inotify_linux_test.go b/src/pkg/exp/inotify/inotify_linux_test.go index d035ec1410f..c2160fc6537 100644 --- a/src/pkg/exp/inotify/inotify_linux_test.go +++ b/src/pkg/exp/inotify/inotify_linux_test.go @@ -83,14 +83,15 @@ func TestInotifyClose(t *testing.T) { watcher, _ := NewWatcher() watcher.Close() - done := false + done := make(chan bool) go func() { watcher.Close() - done = true + done <- true }() - time.Sleep(50 * time.Millisecond) - if !done { + select { + case <-done: + case <-time.After(50 * time.Millisecond): t.Fatal("double Close() test failed: second Close() call didn't return") }