qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 18:54:41 -07:00
Code Releases Activity

runtime: temporary disable concurrent GC sweep

Browse Source 
We see failures on builders, e.g.:
http://build.golang.org/log/70bb28cd6bcf8c4f49810a011bb4337a61977bf4

LGTM=rsc, dave
R=rsc, dave
CC=golang-codereviews
https://golang.org/cl/62360043
This commit is contained in:
Dmitriy Vyukov 2014-02-13 00:03:27 +04:00
parent 2cae0591cd
commit 3cac829ff4
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/pkg/runtime/mgc0.c
View File

@ -2383,6 +2383,8 @@ gc(struct gc_args *args)
sweep.nspan = runtime·mheap.nspan; sweep.nspan = runtime·mheap.nspan;
sweep.spanidx = 0; sweep.spanidx = 0;
// Temporary disable concurrent sweep, because we see failures on builders.
if(false) {
runtime·lock(&gclock); runtime·lock(&gclock);
if(sweep.g == nil) if(sweep.g == nil)
sweep.g = runtime·newproc1(&bgsweepv, nil, 0, 0, runtime·gc); sweep.g = runtime·newproc1(&bgsweepv, nil, 0, 0, runtime·gc);
@ -2391,6 +2393,11 @@ gc(struct gc_args *args)
runtime·ready(sweep.g); runtime·ready(sweep.g);
} }
runtime·unlock(&gclock); runtime·unlock(&gclock);
} else {
// Sweep all spans eagerly.
while(runtime·sweepone() != -1)
gcstats.npausesweep++;
}
runtime·MProf_GC(); runtime·MProf_GC();
} }