From 39852bf4cce6927e01d0136c7843f65a801738cb Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Sat, 24 Feb 2018 10:52:04 +0530 Subject: [PATCH] archive/tar: remove loop label from reader CL 14624 introduced this label. At that time, the switch-case had a break to label statement which made this necessary. But now, the code no longer has a break statement and it directly returns. Hence, it is no longer necessary to have a label. Change-Id: Idde0fcc4d2db2d76424679f5acfe33ab8573bce4 Reviewed-on: https://go-review.googlesource.com/96935 Reviewed-by: Joe Tsai --- src/archive/tar/reader.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/archive/tar/reader.go b/src/archive/tar/reader.go index ccfedb5851e..39437185179 100644 --- a/src/archive/tar/reader.go +++ b/src/archive/tar/reader.go @@ -64,7 +64,6 @@ func (tr *Reader) next() (*Header, error) { // normally be visible to the outside. As such, this loop iterates through // one or more "header files" until it finds a "normal file". format := FormatUSTAR | FormatPAX | FormatGNU -loop: for { // Discard the remainder of the file and any padding. if err := discard(tr.r, tr.curr.PhysicalRemaining()); err != nil { @@ -102,7 +101,7 @@ loop: Format: format, }, nil } - continue loop // This is a meta header affecting the next header + continue // This is a meta header affecting the next header case TypeGNULongName, TypeGNULongLink: format.mayOnlyBe(FormatGNU) realname, err := ioutil.ReadAll(tr) @@ -117,7 +116,7 @@ loop: case TypeGNULongLink: gnuLongLink = p.parseString(realname) } - continue loop // This is a meta header affecting the next header + continue // This is a meta header affecting the next header default: // The old GNU sparse format is handled here since it is technically // just a regular file with additional attributes.