qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 04:24:36 -06:00
Code Releases Activity

cmd/internal/obj: use panic instead of log.Fatalf for two messages

Browse Source 
These messages can happen if there are
duplicate body-less function declarations.
Using panic gives the panic handler
a chance to handle the panic by printing the
queued error messages instead of an internal error.

And if there are no queued error messages,
using panic pinpoints the stack trace leading
to the incorrect use of NewFuncInfo/NewFileInfo.

Change-Id: I7e7ea9822ff9a1e7140f5e5b7cfd6437ff9318a7
Reviewed-on: https://go-review.googlesource.com/c/go/+/266338
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
This commit is contained in:
Russ Cox 2020-10-29 13:57:12 -04:00
parent aa4f48b751
commit 38d1ec8c9d
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/cmd/internal/obj/link.go
View File

@ -38,7 +38,6 @@ import (
"cmd/internal/src"
"cmd/internal/sys"
"fmt"
"log"
"sync"
)
@ -471,7 +470,7 @@ type FuncInfo struct {
// NewFuncInfo allocates and returns a FuncInfo for LSym.
func (s *LSym) NewFuncInfo() *FuncInfo {
if s.Extra != nil {
log.Fatalf("invalid use of LSym - NewFuncInfo with Extra of type %T", *s.Extra)
panic(fmt.Sprintf("invalid use of LSym - NewFuncInfo with Extra of type %T", *s.Extra))
}
f := new(FuncInfo)
s.Extra = new(interface{})
@ -498,7 +497,7 @@ type FileInfo struct {
// NewFileInfo allocates and returns a FileInfo for LSym.
func (s *LSym) NewFileInfo() *FileInfo {
if s.Extra != nil {
log.Fatalf("invalid use of LSym - NewFileInfo with Extra of type %T", *s.Extra)
panic(fmt.Sprintf("invalid use of LSym - NewFileInfo with Extra of type %T", *s.Extra))
}
f := new(FileInfo)
s.Extra = new(interface{})