qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 20:40:03 -07:00
Code Releases Activity

cmd/compile/internal/types2: enable TestIssue25627

Browse Source 
Since we have syntax.Walk, we can make this test work again.

Change-Id: I55cbde7303e5bcbe1123b6679f2ce859d377fd86
Reviewed-on: https://go-review.googlesource.com/c/go/+/294472
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
This commit is contained in:
Robert Griesemer 2021-02-19 16:47:04 -08:00
parent 1901e2647f
commit 378f73e2d5
1 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/cmd/compile/internal/types2/issues_test.go
View File

@ -300,8 +300,6 @@ func TestIssue22525(t *testing.T) {
} }
func TestIssue25627(t *testing.T) { func TestIssue25627(t *testing.T) {
t.Skip("requires syntax tree inspection")
const prefix = `package p; import "unsafe"; type P *struct{}; type I interface{}; type T ` const prefix = `package p; import "unsafe"; type P *struct{}; type I interface{}; type T `
// The src strings (without prefix) are constructed such that the number of semicolons // The src strings (without prefix) are constructed such that the number of semicolons
// plus one corresponds to the number of fields expected in the respective struct. // plus one corresponds to the number of fields expected in the respective struct.
@ -325,20 +323,17 @@ func TestIssue25627(t *testing.T) {
} }
} }
unimplemented() syntax.Walk(f, func(n syntax.Node) bool {
/* if decl, _ := n.(*syntax.TypeDecl); decl != nil {
ast.Inspect(f, func(n syntax.Node) bool { if tv, ok := info.Types[decl.Type]; ok && decl.Name.Value == "T" {
if spec, _ := n.(*syntax.TypeDecl); spec != nil { want := strings.Count(src, ";") + 1
if tv, ok := info.Types[spec.Type]; ok && spec.Name.Value == "T" { if got := tv.Type.(*Struct).NumFields(); got != want {
want := strings.Count(src, ";") + 1 t.Errorf("%s: got %d fields; want %d", src, got, want)
if got := tv.Type.(*Struct).NumFields(); got != want {
t.Errorf("%s: got %d fields; want %d", src, got, want)
}
} }
} }
return true }
}) return false
*/ })
} }
} }