qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-14 06:10:24 -07:00
Code Releases Activity

add test and docs

Browse Source 
Change-Id: Ib2ffbc1d77c82ed3d32c660d53b5cec741936cb2
This commit is contained in:
Mateusz Poliwczak 2024-04-13 07:42:35 +02:00
parent d13d6d0c95
commit 3643528a65
3 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/net/dnsclient_unix.go
View File

@ -318,6 +318,8 @@ func (r *Resolver) tryOneName(ctx context.Context, cfg *dnsConfig, name string,
if err := checkHeader(&p, h); err != nil {
if err == errNoSuchHost {
// The name does not exist, so trying
// another server won't help.
return p, server, newDNSError(errNoSuchHost, name, server)
}
lastErr = newDNSError(err, name, server)
@ -326,6 +328,8 @@ func (r *Resolver) tryOneName(ctx context.Context, cfg *dnsConfig, name string,
if err := skipToAnswer(&p, qtype); err != nil {
if err == errNoSuchHost {
// The name does not exist, so trying
// another server won't help.
return p, server, newDNSError(errNoSuchHost, name, server)
}
lastErr = newDNSError(err, name, server)

26
src/net/lookup_test.go
View File

@ -1630,3 +1630,29 @@ func TestLookupNoSuchHost(t *testing.T) {
})
}
}
func TestDNSErrorUnwrap(t *testing.T) {
rDeadlineExcceeded := &Resolver{PreferGo: true, Dial: func(ctx context.Context, network, address string) (Conn, error) {
return nil, context.DeadlineExceeded
}}
rCancelled := &Resolver{PreferGo: true, Dial: func(ctx context.Context, network, address string) (Conn, error) {
return nil, context.Canceled
}}
_, err := rDeadlineExcceeded.LookupHost(context.Background(), "test.go.dev")
if !errors.Is(err, context.DeadlineExceeded) {
t.Errorf("errors.Is(err, context.DeadlineExceeded) = false; want = true")
}
_, err = rCancelled.LookupHost(context.Background(), "test.go.dev")
if !errors.Is(err, context.Canceled) {
t.Errorf("errors.Is(err, context.Canceled) = false; want = true")
}
ctx, cancel := context.WithCancel(context.Background())
cancel()
_, err = goResolver.LookupHost(ctx, "text.go.dev")
if !errors.Is(err, context.Canceled) {
t.Errorf("errors.Is(err, context.Canceled) = false; want = true")
}
}

2
src/net/net.go
View File

@ -627,6 +627,8 @@ type notFoundError struct{ s string }
func (e *notFoundError) Error() string { return e.s }
// temporaryError is an error type that implements the [Error] interface.
// It returns true from the Temporary method.
type temporaryError struct{ s string }
func (e *temporaryError) Error() string { return e.s }