qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-24 03:50:18 -07:00
Code Releases Activity

os/exec: deflake TestStdinCloseRace

Browse Source 
Stop reporting errors from cmd.Process.Kill; they don't matter for
purposes of this test, and they can occur if the process exits quickly.

Fixes #19211.
Fixes #19213.

Change-Id: I1a0bb9170220ca69199abb8e8811b1dde43e1897
Reviewed-on: https://go-review.googlesource.com/37309
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Ian Lance Taylor 2017-02-21 07:14:51 -08:00
parent a355639c60
commit 35ffca31b1
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/os/exec/exec_test.go
View File

@ -263,9 +263,13 @@ func TestStdinCloseRace(t *testing.T) {
t.Fatalf("Start: %v", err) t.Fatalf("Start: %v", err)
} }
go func() { go func() {
if err := cmd.Process.Kill(); err != nil { // We don't check the error return of Kill. It is
t.Errorf("Kill: %v", err) // possible that the process has already exited, in
} // which case Kill will return an error "process
// already finished". The purpose of this test is to
// see whether the race detector reports an error; it
// doesn't matter whether this Kill succeeds or not.
cmd.Process.Kill()
}() }()
go func() { go func() {
// Send the wrong string, so that the child fails even // Send the wrong string, so that the child fails even