qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-21 23:34:42 -07:00
Code Releases Activity

testing: fix wording in explanation of potential bug

Browse Source 
TBR=rsc

R=rsc
CC=golang-dev
https://golang.org/cl/5504075
This commit is contained in:
Rob Pike 2011-12-22 11:08:51 -08:00
parent 66155134a7
commit 34139ee155
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/pkg/testing/testing.go
View File

@ -240,9 +240,9 @@ func RunTests(matchString func(pat, str string) (bool, error), tests []InternalT
runtime.GOMAXPROCS(procs)
// We build a new channel tree for each run of the loop.
// collector merges in one channel all the upstream signals from parallel tests.
// If all tests pump to the same channel, a bug can occur where a goroutine
// kicks off a test, fails, and still delivers a completion signal, which skews the
// counting.
// If all tests pump to the same channel, a bug can occur where a test
// kicks off a gouroutine that Fails, yet the test still delivers a completion signal,
// which skews the counting.
var collector = make(chan interface{})
numParallel := 0