qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-30 14:38:33 -06:00
Code Releases Activity

gopls/internal/hooks: don't run staticcheck's SA5011

Browse Source 
SA5011 relies on facts from dependencies to avoid false positives.
However, gopls currently only loads export data for dependencies, it
does not compute facts.

SA5011 is unlike other analyzers in staticcheck, which may produce
false negatives if facts are missing, but no false positives.

Change-Id: I5063b701bbedca7b09d1894997f8c574fa497939
Reviewed-on: https://go-review.googlesource.com/c/tools/+/228119
Run-TryBot: Dominik Honnef <dominik@honnef.co>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Dominik Honnef 2020-04-14 05:03:49 +02:00
parent a4a177c7d7
commit 332987a829
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gopls/internal/hooks/analysis.go
View File

@ -17,11 +17,15 @@ func updateAnalyzers(options *source.Options) {
options.AddDefaultAnalyzer(a)
}
for _, a := range staticcheck.Analyzers {
// This check conflicts with the vet printf check (golang/go#34494).
if a.Name == "SA5009" {
continue
switch a.Name {
case "SA5009":
// This check conflicts with the vet printf check (golang/go#34494).
case "SA5011":
// This check relies on facts from dependencies, which
// we don't currently compute.
default:
options.AddDefaultAnalyzer(a)
}
options.AddDefaultAnalyzer(a)
}
for _, a := range stylecheck.Analyzers {
options.AddDefaultAnalyzer(a)