From 323212b9e6edd55e99d973d00d2132995762c858 Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Sun, 9 Jun 2019 12:04:23 -0400 Subject: [PATCH] cmd/go: fix syntax mistake in a testscript file, take 2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a followup to CL 181278 and CL 181177. According to cmd/go/testdata/script/README: Each line is parsed into a sequence of space-separated command words, with environment variable expansion and # marking an end-of-line comment. Adding single quotes around text keeps spaces in that text from being treated as word separators and also disables environment variable expansion. We want $HOME to be expanded, so leave it out of the single-quoted block of text. I tested this change on macOS, and it makes TestScript/env_write pass. Fixes #32503 Change-Id: I13621aec82263e5cb6978c13a1ad71d2210a0e42 Reviewed-on: https://go-review.googlesource.com/c/go/+/181418 Run-TryBot: Dmitri Shuralyov Reviewed-by: Daniel Martí TryBot-Result: Gobot Gobot --- src/cmd/go/testdata/script/env_write.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/go/testdata/script/env_write.txt b/src/cmd/go/testdata/script/env_write.txt index ea15087c5d3..695cc83f3d7 100644 --- a/src/cmd/go/testdata/script/env_write.txt +++ b/src/cmd/go/testdata/script/env_write.txt @@ -5,7 +5,7 @@ env AppData=$HOME/windowsappdata env home=$HOME/plan9home go env GOENV [aix] stdout $HOME/.config/go/env -[darwin] stdout '$HOME/Library/Application Support/go/env' +[darwin] stdout $HOME'/Library/Application Support/go/env' [freebsd] stdout $HOME/.config/go/env [linux] stdout $HOME/.config/go/env [netbsd] stdout $HOME/.config/go/env