qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 17:16:54 -07:00
Code Releases Activity

cmd/link: issue error if elf header overruns

Browse Source 
This is probably unlikely in practice, but when debugging alignment
related issues on ppc64 using very small text section splits, the elf
header could grow beyond the preallocated space and quietly stomp
on the first few text sections.

Change-Id: Ided58aa0b1e60f9da4b3cb277e4ebafcee4ec693
Reviewed-on: https://go-review.googlesource.com/c/go/+/307430
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
This commit is contained in:
Paul E. Murphy 2021-04-05 13:36:13 -05:00 committed by Lynn Boger
parent 7ad496b6f5
commit 31e12b953a
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/link/internal/ld/elf.go
View File

@ -2194,6 +2194,12 @@ elfobj:
if a > elfreserve { if a > elfreserve {
Errorf(nil, "ELFRESERVE too small: %d > %d with %d text sections", a, elfreserve, numtext) Errorf(nil, "ELFRESERVE too small: %d > %d with %d text sections", a, elfreserve, numtext)
} }
// Verify the amount of space allocated for the elf header is sufficient. The file offsets are
// already computed in layout, so we could spill into another section.
if a > int64(HEADR) {
Errorf(nil, "HEADR too small: %d > %d with %d text sections", a, HEADR, numtext)
}
} }
func elfadddynsym(ldr *loader.Loader, target *Target, syms *ArchSyms, s loader.Sym) { func elfadddynsym(ldr *loader.Loader, target *Target, syms *ArchSyms, s loader.Sym) {