From 2fcf90cfacd0502b7fd87fe67e54e2cccc07310a Mon Sep 17 00:00:00 2001 From: Robert Griesemer Date: Wed, 21 May 2014 09:55:02 -0700 Subject: [PATCH] go.tools/go/types: re-disable float_lit2.go std test go/types doesn't correctly round the largest possible float32 literal values and fails. Instead of relying on Rat.Float64 and float32 conversion, we need a Rat.Float32 implementation with correct rounding. LGTM=adonovan R=adonovan CC=golang-codereviews https://golang.org/cl/96540045 --- go/types/stdlib_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/go/types/stdlib_test.go b/go/types/stdlib_test.go index 86da779766b..174c6ceebf4 100644 --- a/go/types/stdlib_test.go +++ b/go/types/stdlib_test.go @@ -119,6 +119,7 @@ func TestStdTest(t *testing.T) { testTestDir(t, filepath.Join(runtime.GOROOT(), "test"), "cmplxdivide.go", // also needs file cmplxdivide1.go - ignore "sigchld.go", // don't work on Windows; testTestDir should consult build tags + "float_lit2.go", // TODO(gri) float32 constant conversion requires (missing) Rat.Float32 ) }