qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-14 13:20:30 -07:00
Code Releases Activity

runtime: remove linkname from memhash{32,64} functions

Browse Source 
Remove linkname directives that are no longer necessary given
parquet-go/parquet-go#142 removes the dependency on the `memhash{32,64}`
functions.

This change also removes references to segmentio/parquet-go since that
repository was archived in favor of parquet-go/parquet-go.

Updates #67401

Change-Id: Ibafb0c41b39cdb86dac5531f62787fb5cb8d3f01
GitHub-Last-Rev: e14c4e4dfe
GitHub-Pull-Request: golang/go#67784
Reviewed-on: https://go-review.googlesource.com/c/go/+/589795
Auto-Submit: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
This commit is contained in:
Alfonso Subiotto Marques 2024-06-03 12:02:40 +00:00 committed by Gopher Robot
parent 11a03bbbd7
commit 2e9ed44d39
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/runtime/alg.go
View File

@ -57,8 +57,6 @@ var useAeshash bool
// - github.com/outcaste-io/ristretto // - github.com/outcaste-io/ristretto
// - github.com/puzpuzpuz/xsync/v2 // - github.com/puzpuzpuz/xsync/v2
// - github.com/puzpuzpuz/xsync/v3 // - github.com/puzpuzpuz/xsync/v3
// - github.com/segmentio/parquet-go
// - github.com/parquet-go/parquet-go
// - github.com/authzed/spicedb // - github.com/authzed/spicedb
// - github.com/pingcap/badger // - github.com/pingcap/badger
// //
@ -68,28 +66,8 @@ var useAeshash bool
//go:linkname memhash //go:linkname memhash
func memhash(p unsafe.Pointer, h, s uintptr) uintptr func memhash(p unsafe.Pointer, h, s uintptr) uintptr
// memhash32 should be an internal detail,
// but widely used packages access it using linkname.
// Notable members of the hall of shame include:
// - github.com/segmentio/parquet-go
// - github.com/parquet-go/parquet-go
//
// Do not remove or change the type signature.
// See go.dev/issue/67401.
//
//go:linkname memhash32
func memhash32(p unsafe.Pointer, h uintptr) uintptr func memhash32(p unsafe.Pointer, h uintptr) uintptr
// memhash64 should be an internal detail,
// but widely used packages access it using linkname.
// Notable members of the hall of shame include:
// - github.com/segmentio/parquet-go
// - github.com/parquet-go/parquet-go
//
// Do not remove or change the type signature.
// See go.dev/issue/67401.
//
//go:linkname memhash64
func memhash64(p unsafe.Pointer, h uintptr) uintptr func memhash64(p unsafe.Pointer, h uintptr) uintptr
// strhash should be an internal detail, // strhash should be an internal detail,