diff --git a/src/cmd/asm/internal/arch/arch.go b/src/cmd/asm/internal/arch/arch.go index bff9177675e..6159ede6c56 100644 --- a/src/cmd/asm/internal/arch/arch.go +++ b/src/cmd/asm/internal/arch/arch.go @@ -44,14 +44,6 @@ func nilRegisterNumber(name string, n int16) (int16, bool) { return 0, false } -var Pseudos = map[string]obj.As{ - "DATA": obj.ADATA, - "FUNCDATA": obj.AFUNCDATA, - "GLOBL": obj.AGLOBL, - "PCDATA": obj.APCDATA, - "TEXT": obj.ATEXT, -} - // Set configures the architecture specified by GOARCH and returns its representation. // It returns nil if GOARCH is not recognized. func Set(GOARCH string) *Arch { diff --git a/src/cmd/asm/internal/asm/parse.go b/src/cmd/asm/internal/asm/parse.go index f4f204b2d37..ee374399620 100644 --- a/src/cmd/asm/internal/asm/parse.go +++ b/src/cmd/asm/internal/asm/parse.go @@ -183,12 +183,10 @@ func (p *Parser) line() bool { p.errorf("missing operand") } } - i, present := arch.Pseudos[word] - if present { - p.pseudo(i, word, operands) + if p.pseudo(word, operands) { return true } - i, present = p.arch.Instructions[word] + i, present := p.arch.Instructions[word] if present { p.instruction(i, word, cond, operands) return true @@ -214,21 +212,22 @@ func (p *Parser) instruction(op obj.As, word, cond string, operands [][]lex.Toke p.asmInstruction(op, cond, p.addr) } -func (p *Parser) pseudo(op obj.As, word string, operands [][]lex.Token) { - switch op { - case obj.ATEXT: - p.asmText(word, operands) - case obj.ADATA: +func (p *Parser) pseudo(word string, operands [][]lex.Token) bool { + switch word { + case "DATA": p.asmData(word, operands) - case obj.AGLOBL: - p.asmGlobl(word, operands) - case obj.APCDATA: - p.asmPCData(word, operands) - case obj.AFUNCDATA: + case "FUNCDATA": p.asmFuncData(word, operands) + case "GLOBL": + p.asmGlobl(word, operands) + case "PCDATA": + p.asmPCData(word, operands) + case "TEXT": + p.asmText(word, operands) default: - p.errorf("unimplemented: %s", word) + return false } + return true } func (p *Parser) start(operand []lex.Token) { diff --git a/src/cmd/asm/internal/asm/pseudo_test.go b/src/cmd/asm/internal/asm/pseudo_test.go index 2e6d6c8154f..16979730e93 100644 --- a/src/cmd/asm/internal/asm/pseudo_test.go +++ b/src/cmd/asm/internal/asm/pseudo_test.go @@ -9,7 +9,6 @@ import ( "strings" "testing" - "cmd/asm/internal/arch" "cmd/asm/internal/lex" ) @@ -58,11 +57,9 @@ func TestErroneous(t *testing.T) { parser.errorCount = 0 parser.lineNum++ parser.histLineNum++ - op, ok := arch.Pseudos[test.pseudo] - if !ok { + if !parser.pseudo(test.pseudo, tokenize(test.operands)) { t.Fatalf("Wrong pseudo-instruction: %s", test.pseudo) } - parser.pseudo(op, test.pseudo, tokenize(test.operands)) errorLine := buf.String() if test.expected != errorLine { t.Errorf("Unexpected error %q; expected %q", errorLine, test.expected) diff --git a/src/cmd/internal/obj/link.go b/src/cmd/internal/obj/link.go index cfd4c736751..430fab3b3e6 100644 --- a/src/cmd/internal/obj/link.go +++ b/src/cmd/internal/obj/link.go @@ -266,7 +266,6 @@ const ( AXXX As = iota ACALL ACHECKNIL - ADATA // used only by the assembler for parsing ADUFFCOPY ADUFFZERO AEND diff --git a/src/cmd/internal/obj/util.go b/src/cmd/internal/obj/util.go index 05cfd8c7209..18450962eda 100644 --- a/src/cmd/internal/obj/util.go +++ b/src/cmd/internal/obj/util.go @@ -603,7 +603,6 @@ var Anames = []string{ "XXX", "CALL", "CHECKNIL", - "DATA", "DUFFCOPY", "DUFFZERO", "END",