1
0
mirror of https://github.com/golang/go synced 2024-11-27 01:21:18 -07:00

crypto/md5: fix for big-endian processors

R=golang-dev, minux.ma, agl
CC=golang-dev
https://golang.org/cl/7305059
This commit is contained in:
Ian Lance Taylor 2013-02-07 13:31:53 -08:00
parent 514f10b9ab
commit 2b44c33b4a

View File

@ -5,6 +5,16 @@ import (
"unsafe" "unsafe"
) )
const x86 = runtime.GOARCH == "amd64" || runtime.GOARCH == "386"
var littleEndian bool
func init() {
x := uint32(0x04030201)
y := [4]byte{0x1, 0x2, 0x3, 0x4}
littleEndian = *(*[4]byte)(unsafe.Pointer(&x)) == y
}
func block(dig *digest, p []byte) { func block(dig *digest, p []byte) {
a := dig.s[0] a := dig.s[0]
b := dig.s[1] b := dig.s[1]
@ -16,13 +26,13 @@ func block(dig *digest, p []byte) {
aa, bb, cc, dd := a, b, c, d aa, bb, cc, dd := a, b, c, d
// This is a constant condition - it is not evaluated on each iteration. // This is a constant condition - it is not evaluated on each iteration.
if runtime.GOARCH == "amd64" || runtime.GOARCH == "386" { if x86 {
// MD5 was designed so that x86 processors can just iterate // MD5 was designed so that x86 processors can just iterate
// over the block data directly as uint32s, and we generate // over the block data directly as uint32s, and we generate
// less code and run 1.3x faster if we take advantage of that. // less code and run 1.3x faster if we take advantage of that.
// My apologies. // My apologies.
X = (*[16]uint32)(unsafe.Pointer(&p[0])) X = (*[16]uint32)(unsafe.Pointer(&p[0]))
} else if uintptr(unsafe.Pointer(&p[0]))&(unsafe.Alignof(uint32(0))-1) == 0 { } else if littleEndian && uintptr(unsafe.Pointer(&p[0]))&(unsafe.Alignof(uint32(0))-1) == 0 {
X = (*[16]uint32)(unsafe.Pointer(&p[0])) X = (*[16]uint32)(unsafe.Pointer(&p[0]))
} else { } else {
X = &xbuf X = &xbuf