qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-20 10:14:43 -07:00
Code Releases Activity

go/constant: document that BinaryOp doesn't handle comparisons or shifts

Browse Source 
Fixes #17797.

Change-Id: I544df81c4bcf3cbd36a793be40050f14f9a9974f
Reviewed-on: https://go-review.googlesource.com/32761
Reviewed-by: Dominik Honnef <dominik@honnef.co>
This commit is contained in:
Robert Griesemer 2016-11-05 13:14:23 -07:00
parent d0cf042171
commit 2b445c7645
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/go/constant/value.go
View File

@ -936,6 +936,9 @@ func match(x, y Value) (_, _ Value) {
// BinaryOp returns the result of the binary expression x op y. // BinaryOp returns the result of the binary expression x op y.
// The operation must be defined for the operands. If one of the // The operation must be defined for the operands. If one of the
// operands is Unknown, the result is Unknown. // operands is Unknown, the result is Unknown.
// BinaryOp doesn't handle comparisons or shifts; use Compare
// or Shift instead.
//
// To force integer division of Int operands, use op == token.QUO_ASSIGN // To force integer division of Int operands, use op == token.QUO_ASSIGN
// instead of token.QUO; the result is guaranteed to be Int in this case. // instead of token.QUO; the result is guaranteed to be Int in this case.
// Division by zero leads to a run-time panic. // Division by zero leads to a run-time panic.