qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 07:10:05 -07:00
Code Releases Activity

syscall, cmd/cgo: skip tests that shouldn't run under 'unshare -n -r'

Browse Source 
A small number of tests in the main tree are currently skipped in LUCI
because our builders there run tests without root. Unfortunately, these
tests begin to run when run under 'unshare -n -r' as implemented in
the current iteration of a no-network check. Add targeted builder-only
skips so that they don't begin to run and fail with a false positive.

Updates #10719.
For #30612.

Change-Id: I6dd320714a279c395882c1b2ebfbb2fce58f913b
Reviewed-on: https://go-review.googlesource.com/c/go/+/513779
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
Dmitri Shuralyov 2023-07-27 19:36:55 -04:00 committed by Gopher Robot
parent f322d67ced
commit 2ad666dea0
4 changed files with 47 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/cmd/cgo/internal/test/issue1435.go
View File

@ -8,6 +8,7 @@ package cgotest
import (
"fmt"
"internal/testenv"
"os"
"runtime"
"sort"
@ -145,6 +146,13 @@ func test1435(t *testing.T) {
if syscall.Getuid() != 0 {
t.Skip("skipping root only test")
}
if testing.Short() && testenv.Builder() != "" && os.Getenv("USER") == "swarming" {
// The Go build system's swarming user is known not to be root.
// Unfortunately, it sometimes appears as root due the current
// implementation of a no-network check using 'unshare -n -r'.
// Since this test does need root to work, we need to skip it.
t.Skip("skipping root only test on a non-root builder")
}
if runtime.GOOS == "linux" {
if _, err := os.Stat("/etc/alpine-release"); err == nil {
t.Skip("skipping failing test on alpine - go.dev/issue/19938")

16
src/syscall/exec_linux_test.go
View File

@ -249,6 +249,14 @@ func TestUnshareMountNameSpace(t *testing.T) {
if testenv.SyscallIsNotSupported(err) {
t.Skipf("skipping: could not start process with CLONE_NEWNS: %v", err)
}
if testing.Short() && testenv.Builder() != "" && os.Getenv("USER") == "swarming" {
// The Go build system's swarming user is known not to support
// starting a process with CLONE_NEWNS.
// Unfortunately, it doesn't get recognized as such due the current
// implementation of a no-network check using 'unshare -n -r'.
// Since this test does need start this process, we need to skip it.
t.Skipf("skipping: could not start process with CLONE_NEWNS: %v", err)
}
t.Fatalf("unshare failed: %v\n%s", err, o)
}
@ -301,6 +309,14 @@ func TestUnshareMountNameSpaceChroot(t *testing.T) {
if testenv.SyscallIsNotSupported(err) {
t.Skipf("skipping: could not start process with CLONE_NEWNS and Chroot %q: %v", d, err)
}
if testing.Short() && testenv.Builder() != "" && os.Getenv("USER") == "swarming" {
// The Go build system's swarming user is known not to support
// starting a process with CLONE_NEWNS and Chroot.
// Unfortunately, it doesn't get recognized as such due the current
// implementation of a no-network check using 'unshare -n -r'.
// Since this test does need start this process, we need to skip it.
t.Skipf("skipping: could not start process with CLONE_NEWNS and Chroot %q: %v", d, err)
}
t.Fatalf("unshare failed: %v\n%s", err, o)
}

8
src/syscall/exec_pdeathsig_test.go
View File

@ -9,6 +9,7 @@ package syscall_test
import (
"bufio"
"fmt"
"internal/testenv"
"io"
"os"
"os/exec"
@ -23,6 +24,13 @@ func TestDeathSignal(t *testing.T) {
if os.Getuid() != 0 {
t.Skip("skipping root only test")
}
if testing.Short() && testenv.Builder() != "" && os.Getenv("USER") == "swarming" {
// The Go build system's swarming user is known not to be root.
// Unfortunately, it sometimes appears as root due the current
// implementation of a no-network check using 'unshare -n -r'.
// Since this test does need root to work, we need to skip it.
t.Skip("skipping root only test on a non-root builder")
}
// Copy the test binary to a location that a non-root user can read/execute
// after we drop privileges

15
src/syscall/syscall_linux_test.go
View File

@ -6,6 +6,7 @@ package syscall_test
import (
"fmt"
"internal/testenv"
"io"
"io/fs"
"os"
@ -198,6 +199,13 @@ func TestSyscallNoError(t *testing.T) {
if os.Getuid() != 0 {
t.Skip("skipping root only test")
}
if testing.Short() && testenv.Builder() != "" && os.Getenv("USER") == "swarming" {
// The Go build system's swarming user is known not to be root.
// Unfortunately, it sometimes appears as root due the current
// implementation of a no-network check using 'unshare -n -r'.
// Since this test does need root to work, we need to skip it.
t.Skip("skipping root only test on a non-root builder")
}
if runtime.GOOS == "android" {
t.Skip("skipping on rooted android, see issue 27364")
@ -516,6 +524,13 @@ func TestSetuidEtc(t *testing.T) {
if syscall.Getuid() != 0 {
t.Skip("skipping root only test")
}
if testing.Short() && testenv.Builder() != "" && os.Getenv("USER") == "swarming" {
// The Go build system's swarming user is known not to be root.
// Unfortunately, it sometimes appears as root due the current
// implementation of a no-network check using 'unshare -n -r'.
// Since this test does need root to work, we need to skip it.
t.Skip("skipping root only test on a non-root builder")
}
if _, err := os.Stat("/etc/alpine-release"); err == nil {
t.Skip("skipping glibc test on alpine - go.dev/issue/19938")
}