qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-13 19:30:22 -07:00
Code Releases Activity

os: read only 10,000 bytes at a time from Windows console

Browse Source 
Reading 32,767 is too many on some versions of Windows.
The exact upper bound is unclear.

For #13697, but may not fix the problem on all systems.

Change-Id: I197021ed60cbcd33c91ca6ceed456ec3d5a6c9d6
Reviewed-on: https://go-review.googlesource.com/18433
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Russ Cox 2016-01-08 11:23:25 -05:00
parent 5ccaf0255b
commit 29eea94abe
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/os/file_windows.go
View File

@ -265,8 +265,10 @@ func (f *File) readConsole(b []byte) (n int, err error) {
if len(f.readbuf) == 0 { if len(f.readbuf) == 0 {
numBytes := len(b) numBytes := len(b)
// Windows can't read bytes over max of int16. // Windows can't read bytes over max of int16.
if numBytes > 32767 { // Some versions of Windows can read even less.
numBytes = 32767 // See golang.org/issue/13697.
if numBytes > 10000 {
numBytes = 10000
} }
mbytes := make([]byte, numBytes) mbytes := make([]byte, numBytes)
var nmb uint32 var nmb uint32