qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-05 11:46:12 -07:00
Code Releases Activity

cmd/go: always log dynamic import errors

Browse Source 
There is no easy way to understand what user intent was and whether
they wanted to use a dynamic import or not.

If we skip logging such errors, it breaks common use cases such as
https://golang.org/issue/12810.

It's a better approach to expose the underlying mechanism and
be more verbose with the error messages.

Fixes #12810.

Change-Id: I7e922c9e848382690d9d9b006d7046e6cf93223b
Reviewed-on: https://go-review.googlesource.com/15756
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
This commit is contained in:
Burcu Dogan 2015-10-12 01:02:51 -07:00 committed by Andrew Gerrand
parent 5b9c6b9e9e
commit 29aaf679da
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/cmd/go/vcs.go
View File

@ -567,16 +567,8 @@ func repoRootForImportPath(importPath string, security securityMode) (*repoRoot,
lookup = lookup[:i] lookup = lookup[:i]
} }
rr, err = repoRootForImportDynamic(lookup, security) rr, err = repoRootForImportDynamic(lookup, security)
// repoRootForImportDynamic returns error detail
// that is irrelevant if the user didn't intend to use a
// dynamic import in the first place.
// Squelch it.
if err != nil { if err != nil {
if buildV { err = fmt.Errorf("unrecognized import path %q (%v)", importPath, err)
log.Printf("import %q: %v", importPath, err)
}
err = fmt.Errorf("unrecognized import path %q", importPath)
} }
} }
if err != nil { if err != nil {