qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 22:34:33 -06:00
Code Releases Activity

cmd/go/internal/modload: improve error message for failing to read module listed in go.work

Browse Source 
Run "go build ./x" in this workspace:

  -- go.work --
  use ./y
  -- x/go.mod --
  module x

  go 1.19
  -- x/m.go --
  package m

It fails with: "go: open /tmp/foo/y/go.mod: no such file or directory".
It's unclear where the name "y" comes from.
This change will emit error like: "go: cannot load module listed in
go.work file: open /tmp/foo/y/go.mod: no such file or directory"

Fixes #55952.

Change-Id: Ia45dd915e3fbd6e33340f352b3d6235c6c31190b
GitHub-Last-Rev: 410de1b4a7
GitHub-Pull-Request: golang/go#56050
Reviewed-on: https://go-review.googlesource.com/c/go/+/438147
Run-TryBot: hopehook <hopehook@golangcn.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
This commit is contained in:
Zeke Lu 2022-10-07 00:49:15 +00:00 committed by Gopher Robot
parent 4fe1971b2d
commit 28a05f541d
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/go/internal/modload/init.go
View File

@ -718,7 +718,11 @@ func LoadModFile(ctx context.Context) *Requirements {
var fixed bool
data, f, err := ReadModFile(gomod, fixVersion(ctx, &fixed))
if err != nil {
base.Fatalf("go: %v", err)
if inWorkspaceMode() {
base.Fatalf("go: cannot load module listed in go.work file: %v", err)
} else {
base.Fatalf("go: %v", err)
}
}
modFiles = append(modFiles, f)

11
src/cmd/go/testdata/script/work_use_issue55952.txt vendored Normal file
View File

@ -0,0 +1,11 @@
! go list .
stderr '^go: cannot load module listed in go\.work file: open .+go\.mod:'
-- go.work --
use ./y
-- x/go.mod --
module x
go 1.19
-- x/m.go --
package m