qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 15:54:42 -07:00
Code Releases Activity

runtime: on Plan 9, zero memory returned to the brk by sysFree

Browse Source 
Plan 9's sysFree has an optimization where if the object being freed
is the last object allocated, it will roll back the brk to allow the
memory to be reused by sysAlloc.  However, it does not zero this
"returned" memory, so as a result, sysAlloc can return non-zeroed
memory after a sysFree.  This leads to corruption because the runtime
assumes sysAlloc returns zeroed memory.

Fix this by zeroing the memory returned by sysFree.

Fixes #9846.

Change-Id: Id328c58236eb7c464b31ac1da376a0b757a5dc6a
Reviewed-on: https://go-review.googlesource.com/4700
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: David du Colombier <0intro@gmail.com>
This commit is contained in:
Austin Clements 2015-02-12 10:37:01 -05:00
parent 3b67e9c299
commit 27ed1fcb04
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/runtime/mem_plan9.go
View File

@ -48,6 +48,7 @@ func sysFree(v unsafe.Pointer, n uintptr, stat *uint64) {
n = memRound(n) n = memRound(n)
if bloc == uintptr(v)+n { if bloc == uintptr(v)+n {
bloc -= n bloc -= n
memclr(unsafe.Pointer(bloc), n)
} }
unlock(&memlock) unlock(&memlock)
} }