qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-25 03:10:12 -06:00
Code Releases Activity

net/http: deflake TestClientRedirects

Browse Source 
Fix another case of a parallel test relying on a global variable
(DefaultTransport) implicitly.

Use the private Transport already in scope instead. It's closed at the
end, instead of randomly via another test.

Change-Id: I95e51926177ad19a766cabbb306782ded1bbb59b
Reviewed-on: https://go-review.googlesource.com/32913
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Brad Fitzpatrick 2016-11-08 17:44:53 +00:00
parent 41eb9bb993
commit 27a3d30dd0
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/net/http/client_test.go
View File

@ -251,11 +251,14 @@ func TestClientRedirects(t *testing.T) {
var checkErr error
var lastVia []*Request
var lastReq *Request
c = &Client{CheckRedirect: func(req *Request, via []*Request) error {
lastReq = req
lastVia = via
return checkErr
}}
c = &Client{
Transport: tr,
CheckRedirect: func(req *Request, via []*Request) error {
lastReq = req
lastVia = via
return checkErr
},
}
res, err := c.Get(ts.URL)
if err != nil {
t.Fatalf("Get error: %v", err)