diff --git a/misc/emacs/go-mode.el b/misc/emacs/go-mode.el index 6cc03edb06..b74bc45e8d 100644 --- a/misc/emacs/go-mode.el +++ b/misc/emacs/go-mode.el @@ -950,11 +950,12 @@ will be commented, otherwise they will be removed completely." "Given a file name in the format of `filename:line:column', visit FILENAME and go to line LINE and column COLUMN." (if (not (string-match "\\(.+\\):\\([0-9]+\\):\\([0-9]+\\)" specifier)) - (error "Unexpected godef output: %s" specifier) + ;; We've only been given a directory name + (funcall (if other-window #'find-file-other-window #'find-file) specifier) (let ((filename (match-string 1 specifier)) (line (string-to-number (match-string 2 specifier))) (column (string-to-number (match-string 3 specifier)))) - (with-current-buffer (funcall (if other-window 'find-file-other-window 'find-file) filename) + (with-current-buffer (funcall (if other-window #'find-file-other-window #'find-file) filename) (go--goto-line line) (beginning-of-line) (forward-char (1- column)) @@ -1008,6 +1009,8 @@ description at POINT." (message "%s" file)) ((go--string-prefix-p "godef: no declaration found for " file) (message "%s" file)) + ((go--string-prefix-p "error finding import path for " file) + (message "%s" file)) (t (push-mark) (ring-insert find-tag-marker-ring (point-marker))