qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 08:07:57 -07:00
Code Releases Activity

cmd/nm: don't add filename elements for m symbols

Browse Source 
The compilers used to generate only one 'm' symbol
to record the stack frame size for each function.

In cmd/nm, the 'm' and 'f' symbols are handled in
the same switch case with a special exception for
the symbol described above called ".frame".

Now that the compilers emit additional 'm' symbols
for precise garbage collection of the stack, the
current logic is incorrect. cmd/nm will attempt to
interpret these new 'm' symbols as 'f' symbols and
add them to the file name index table.

This fails with an out-of-memory condition when
zenter encounters an 'm' symbol with a very large
value (usually the .args symbol indicating a
variadic NOSPLIT function).

R=iant
CC=dave, gobot, golang-dev, rsc
https://golang.org/cl/7962045
This commit is contained in:
Anthony Martin 2013-04-03 18:23:43 -07:00
parent 1b9e36356b
commit 272687ec24
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/nm/nm.c
View File

@ -275,11 +275,13 @@ psym(Sym *s, void* p)
return;
break;
case 'm':
if(!aflag || uflag || gflag)
return;
break;
case 'f': /* we only see a 'z' when the following is true*/
if(!aflag || uflag || gflag)
return;
if (strcmp(s->name, ".frame"))
zenter(s);
zenter(s);
break;
case 'a':
case 'p':