qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 06:44:40 -07:00
Code Releases Activity

codereview: fix hgpatch on windows

Browse Source 
R=rsc
CC=golang-dev
https://golang.org/cl/3989059
This commit is contained in:
Yasuhiro Matsumoto 2011-02-02 22:43:40 -05:00 committed by Russ Cox
parent 34336bd9f3
commit 27191b558c
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/codereview/codereview.py
View File

@ -1142,12 +1142,11 @@ def clpatch(ui, repo, clname, **opts):
if err != "": if err != "":
return err return err
try: try:
cmd = subprocess.Popen(argv, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=None, close_fds=True) cmd = subprocess.Popen(argv, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=None, close_fds=sys.platform != "win32")
except: except:
return "hgpatch: " + ExceptionDetail() return "hgpatch: " + ExceptionDetail()
if os.fork() == 0:
cmd.stdin.write(patch) cmd.stdin.write(patch)
os._exit(0)
cmd.stdin.close() cmd.stdin.close()
out = cmd.stdout.read() out = cmd.stdout.read()
if cmd.wait() != 0 and not opts["ignore_hgpatch_failure"]: if cmd.wait() != 0 and not opts["ignore_hgpatch_failure"]: