qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 00:04:41 -07:00
Code Releases Activity

gc: fix &^=

Browse Source 
Fixes #1394.

R=ken2
CC=golang-dev
https://golang.org/cl/3879041
This commit is contained in:
Russ Cox 2011-01-06 11:21:18 -05:00
parent a46102d209
commit 2281ca169c
2 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/cmd/gc/walk.c
View File

@ -960,15 +960,15 @@ walkexpr(Node **np, NodeList **init)
goto ret; goto ret;
case OASOP: case OASOP:
n->left = safeexpr(n->left, init);
walkexpr(&n->left, init);
l = n->left;
walkexpr(&n->right, init);
if(n->etype == OANDNOT) { if(n->etype == OANDNOT) {
n->etype = OAND; n->etype = OAND;
n->right = nod(OCOM, n->right, N); n->right = nod(OCOM, n->right, N);
typecheck(&n->right, Erv); typecheck(&n->right, Erv);
} }
n->left = safeexpr(n->left, init);
walkexpr(&n->left, init);
l = n->left;
walkexpr(&n->right, init);
/* /*
* on 32-bit arch, rewrite 64-bit ops into l = l op r. * on 32-bit arch, rewrite 64-bit ops into l = l op r.

16
test/fixedbugs/bug317.go Normal file
View File

@ -0,0 +1,16 @@
// $G $D/$F.go && $L $F.$A && ./$A.out || echo BUG: bug317
// Copyright 2011 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
func main() {
x := []uint{0}
x[0] &^= f()
}
func f() uint {
return 1<<31 // doesn't panic with 1<<31 - 1
}