qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 19:30:05 -07:00
Code Releases Activity

cmd/pack: don't look for " in output from go env

Browse Source 
Windows at least doesn't emit one.
Maybe fix Windows build.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/66120046
This commit is contained in:
Rob Pike 2014-02-19 15:33:47 -08:00
parent 8ac499916e
commit 2037756fcc
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/cmd/pack/pack_test.go
View File

@ -12,7 +12,7 @@ import (
"os"
"os/exec"
"path/filepath"
"strings"
"regexp"
"testing"
"time"
"unicode/utf8"
@ -193,11 +193,15 @@ func TestHello(t *testing.T) {
}
out := run("go", "env")
i := strings.Index(out, "GOCHAR=\"")
if i < 0 {
re, err := regexp.Compile(`\s*GOCHAR="?(\w)"?`)
if err != nil {
t.Fatal(err)
}
fields := re.FindStringSubmatch(out)
if fields == nil {
t.Fatal("cannot find GOCHAR in 'go env' output:\n", out)
}
char := out[i+8 : i+9]
char := fields[1]
run("go", "build", "cmd/pack") // writes pack binary to dir
run("go", "tool", char+"g", "hello.go")
run("./pack", "grc", "hello.a", "hello."+char)