qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 16:24:28 -06:00
Code Releases Activity

cmd/objdump: skip PIE test when cgo is disabled and PIE needs external linking

Browse Source 
On some platforms, building PIE needs external linking, which
cannot run if cgo is not available.

Change-Id: I6d504aed0f0442cda0355d0beac606ad365e2046
Reviewed-on: https://go-review.googlesource.com/c/go/+/447616
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
Cherry Mui 2022-11-03 12:21:58 -04:00
parent b07e845e76
commit 1f65c399be
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cmd/objdump/objdump_test.go
View File

@ -290,6 +290,10 @@ func TestDisasmPIE(t *testing.T) {
if !platform.BuildModeSupported("gc", "pie", runtime.GOOS, runtime.GOARCH) {
t.Skipf("skipping on %s/%s, PIE buildmode not supported", runtime.GOOS, runtime.GOARCH)
}
if !platform.InternalLinkPIESupported(runtime.GOOS, runtime.GOARCH) {
// require cgo on platforms that PIE needs external linking
testenv.MustHaveCGO(t)
}
t.Parallel()
testDisasm(t, "fmthello.go", false, false, "-buildmode=pie")
}