qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 16:44:43 -07:00
Code Releases Activity

cmd/go: refuse -w with an invalid GO111MODULE

Browse Source 
It was possible to get 'go env' to break itself:

	$ go env -w GO111MODULE=bad
	$ go env
	go: unknown environment setting GO111MODULE=bad

We already check if the variable name is known. In some cases like
GO111MODULE, we also know what the variable's valid values are. Enforce
it when writing the variable, not just when fetching it.

Fixes #34880.

Change-Id: I10d682087c69f3445f314fd4473644f694e255f7
Reviewed-on: https://go-review.googlesource.com/c/go/+/200867
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
Daniel Martí 2019-10-13 22:33:18 +01:00
parent 90888ed97b
commit 1ed932d22b
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/cmd/go/internal/envcmd/env.go
View File

@ -343,6 +343,18 @@ func checkEnvWrite(key, val string, env []cfg.EnvVar) error {
return fmt.Errorf("unknown go command variable %s", key) return fmt.Errorf("unknown go command variable %s", key)
} }
// Some variables can only have one of a few valid values. If set to an
// invalid value, the next cmd/go invocation might fail immediately,
// even 'go env -w' itself.
switch key {
case "GO111MODULE":
switch val {
case "", "auto", "on", "off":
default:
return fmt.Errorf("invalid %s value %q", key, val)
}
}
if !utf8.ValidString(val) { if !utf8.ValidString(val) {
return fmt.Errorf("invalid UTF-8 in %s=... value", key) return fmt.Errorf("invalid UTF-8 in %s=... value", key)
} }

4
src/cmd/go/testdata/script/env_write.txt vendored
View File

@ -85,3 +85,7 @@ stderr 'multiple values for key: GOOS'
# go env -w rejects missing variables # go env -w rejects missing variables
! go env -w GOOS ! go env -w GOOS
stderr 'arguments must be KEY=VALUE: invalid argument: GOOS' stderr 'arguments must be KEY=VALUE: invalid argument: GOOS'
# go env -w rejects invalid GO111MODULE values, as otherwise cmd/go would break
! go env -w GO111MODULE=badvalue
stderr 'invalid GO111MODULE value "badvalue"'