qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 20:40:07 -07:00
Code Releases Activity

go/types: more robust operand printing

Browse Source 
Not a fix but useful for further debugging, and safe.

For #18643.

Change-Id: I5fb4f4a8662007a26e945fff3986347855f00eab
Reviewed-on: https://go-review.googlesource.com/46393
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
Robert Griesemer 2017-06-21 16:20:00 -07:00
parent 7a2fb4048e
commit 1d3a0df4bb
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/go/types/operand.go
View File

@ -122,7 +122,8 @@ func operandString(x *operand, qf Qualifier) string {
case invalid, novalue, builtin, typexpr: case invalid, novalue, builtin, typexpr:
// no type // no type
default: default:
// has type // should have a type, but be cautious (don't crash during printing)
if x.typ != nil {
if isUntyped(x.typ) { if isUntyped(x.typ) {
buf.WriteString(x.typ.(*Basic).name) buf.WriteString(x.typ.(*Basic).name)
buf.WriteByte(' ') buf.WriteByte(' ')
@ -130,6 +131,7 @@ func operandString(x *operand, qf Qualifier) string {
} }
hasType = true hasType = true
} }
}
// <mode> // <mode>
buf.WriteString(operandModeString[x.mode]) buf.WriteString(operandModeString[x.mode])