1
0
mirror of https://github.com/golang/go synced 2024-11-24 01:00:15 -07:00

cmd/go/testdata/script: remove skips and clarify comments in mod_*_upgrade_pseudo tests

These tests were added in CL 174206.

They required a 'git' binary and network access in an earlier draft,
but now use the test-local module proxy instead, so no longer need to
be skipped when those resources are not present.

Updates #30634

Change-Id: I5f36c6c776209a89bc45d133847df5052b55da59
Reviewed-on: https://go-review.googlesource.com/c/go/+/176537
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Bryan C. Mills 2019-05-10 11:10:50 -04:00
parent 2aa8971910
commit 1d1ff46966
2 changed files with 16 additions and 26 deletions

View File

@ -1,19 +1,14 @@
env GO111MODULE=on env GO111MODULE=on
# Testing that a pseudo version with schematically higher version than the latest # For this test module there are three versions:
# tagged version isn't downgraded when running 'go get -u'. # * v0.1.1-0.20190429073117-b5426c86b553
# * v0.1.0
# * v0.0.0-20190429073000-30950c05d534
# Only v0.1.0 is tagged.
#
# The latest pseudo-version is semantically higher than the latest tag.
# 'get -u' should not downgrade to the (lower) tagged version.
[!net] skip
[!exec:git] skip
# For this test repository there are three commits:
# * b5426c8 "master" (v0.1.1-0.20190429073117-b5426c86b553)
# * a90cfd2 (tag: v0.1.0)
# * 30950c0
# When requesting master as specific version, a pseudo version is created with a
# higher version than the latest tag. Running 'go get -u' doesn't downgrade the
# version.
go get -m example.com/pseudoupgrade@b5426c8 go get -m example.com/pseudoupgrade@b5426c8
go get -u go get -u
go list -m -u all go list -m -u all

View File

@ -1,19 +1,14 @@
env GO111MODULE=on env GO111MODULE=on
# Testing that a pseudo version with schematically higher version than the latest # For this test module there are three versions:
# tagged version isn't listed as upgradable when calling 'go list -m -u'. # * v0.1.1-0.20190429073117-b5426c86b553
# * v0.1.0
# * v0.0.0-20190429073000-30950c05d534
# Only v0.1.0 is tagged.
#
# The latest pseudo-version is semantically higher than the latest tag.
# 'list -u' should not suggest a lower version as an upgrade.
[!net] skip
[!exec:git] skip
# For this test repository there are three commits:
# * b5426c8 "master" (v0.1.1-0.20190429073117-b5426c86b553)
# * a90cfd2 (tag: v0.1.0)
# * 30950c0
# When requesting master as specific version, a pseudo version is created with a
# higher version than the latest tag. Listing upgrades doesn't suggest the lower
# version as upgrade.
go get -m example.com/pseudoupgrade@b5426c8 go get -m example.com/pseudoupgrade@b5426c8
go list -m -u all go list -m -u all
stdout '^example.com/pseudoupgrade v0.1.1-0.20190429073117-b5426c86b553$' stdout '^example.com/pseudoupgrade v0.1.1-0.20190429073117-b5426c86b553$'