qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 23:04:40 -07:00
Code Releases Activity

encoding/gob: work around TestFuzzOneByte panic

Browse Source 
The index 248 results in the decoder calling reflect.MakeMapWithSize
with a size of 14754407682 - just under 15GB - which ends up in a
runtime out of memory panic after some recent runtime changes on
machines with 8GB of memory.

Until that is fixed in either runtime or gob, skip the troublesome
index.

Updates #24308.

Change-Id: Ia450217271c983e7386ba2f3f88c9ba50aa346f4
Reviewed-on: https://go-review.googlesource.com/99655
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Daniel Martí 2018-03-08 18:47:07 +00:00
parent 031f71efdf
commit 1c6144d069
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/encoding/gob/codec_test.go
View File

@ -1478,6 +1478,10 @@ func TestFuzzOneByte(t *testing.T) {
switch i {
case 14, 167, 231, 265: // a slice length, corruptions are not handled yet.
continue
case 248:
// Large map size, which currently causes an out of memory panic.
// See golang.org/issue/24308 and golang.org/issue/20221.
continue
}
indices = append(indices, i)
}