qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-13 18:20:32 -07:00
Code Releases Activity

os/exec: fix variable shadow, don't leak goroutine

Browse Source 
Goroutine leak checking is still too tedious, so untested.

See #6705 which is my fault for forgetting to mail out.

Change-Id: I899fb311c9d4229ff1dbd3f54fe307805e17efee
Reviewed-on: https://go-review.googlesource.com/22581
Reviewed-by: Ahmed W. <oneofone@gmail.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Brad Fitzpatrick 2016-04-28 15:16:46 -05:00
parent 6c11e2710e
commit 1b591dfb1f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/os/exec/exec.go
View File

@ -412,7 +412,7 @@ func (c *Cmd) WaitContext(ctx context.Context) error {
var waitDone chan struct{} var waitDone chan struct{}
if ctx != nil { if ctx != nil {
waitDone := make(chan struct{}) waitDone = make(chan struct{})
go func() { go func() {
select { select {
case <-ctx.Done(): case <-ctx.Done():