qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 12:04:43 -07:00
Code Releases Activity

runtime: run the right test in TestCgoExternalThreadSignal

Browse Source 
The code was accidentally repeating the TestCgoExternalThreadSIGPROF test.

While we're here remove an obsolete skip on ppc64/linux.

Change-Id: Icdc4032a67aa80fbcfcd7c5c7ab8a6f23f321e2e
Reviewed-on: https://go-review.googlesource.com/c/go/+/366755
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
Ian Lance Taylor 2021-11-23 12:25:10 -08:00
parent e3eaedb5cf
commit 1ac45e026b
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/runtime/crash_cgo_test.go
View File

@ -94,11 +94,6 @@ func TestCgoExternalThreadSIGPROF(t *testing.T) {
case "plan9", "windows": case "plan9", "windows":
t.Skipf("no pthreads on %s", runtime.GOOS) t.Skipf("no pthreads on %s", runtime.GOOS)
} }
if runtime.GOARCH == "ppc64" && runtime.GOOS == "linux" {
// TODO(austin) External linking not implemented on
// linux/ppc64 (issue #8912)
t.Skipf("no external linking on ppc64")
}
exe, err := buildTestProg(t, "testprogcgo", "-tags=threadprof") exe, err := buildTestProg(t, "testprogcgo", "-tags=threadprof")
if err != nil { if err != nil {
@ -128,7 +123,7 @@ func TestCgoExternalThreadSignal(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
got, err := testenv.CleanCmdEnv(exec.Command(exe, "CgoExternalThreadSIGPROF")).CombinedOutput() got, err := testenv.CleanCmdEnv(exec.Command(exe, "CgoExternalThreadSignal")).CombinedOutput()
if err != nil { if err != nil {
t.Fatalf("exit status: %v\n%s", err, got) t.Fatalf("exit status: %v\n%s", err, got)
} }