qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 18:44:44 -07:00
Code Releases Activity

runtime: remove p padding field for atomic fields alignment

Browse Source 
CL 424396 and CL 424397 changed timer0When/timerModifiedEarliest to
atomic.Uint64, just they're guaranted to have 64-bit alignment.

Change-Id: Idaff1059da2aac84520b9b0e34f9721a74dbba5a
Reviewed-on: https://go-review.googlesource.com/c/go/+/424794
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
This commit is contained in:
Cuong Manh Le 2022-08-18 22:53:19 +07:00 committed by Gopher Robot
parent a5370d038e
commit 1aa5730f49
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/runtime/align_runtime_test.go
View File

@ -14,8 +14,6 @@ import "unsafe"
// operations (all the *64 operations in runtime/internal/atomic). // operations (all the *64 operations in runtime/internal/atomic).
var AtomicFields = []uintptr{ var AtomicFields = []uintptr{
unsafe.Offsetof(m{}.procid), unsafe.Offsetof(m{}.procid),
unsafe.Offsetof(p{}.timer0When),
unsafe.Offsetof(p{}.timerModifiedEarliest),
unsafe.Offsetof(p{}.gcFractionalMarkTime), unsafe.Offsetof(p{}.gcFractionalMarkTime),
unsafe.Offsetof(profBuf{}.overflow), unsafe.Offsetof(profBuf{}.overflow),
unsafe.Offsetof(profBuf{}.overflowTime), unsafe.Offsetof(profBuf{}.overflowTime),

2
src/runtime/runtime2.go
View File

@ -667,8 +667,6 @@ type p struct {
palloc persistentAlloc // per-P to avoid mutex palloc persistentAlloc // per-P to avoid mutex
_ uint32 // Alignment for atomic fields below
// The when field of the first entry on the timer heap. // The when field of the first entry on the timer heap.
// This is 0 if the timer heap is empty. // This is 0 if the timer heap is empty.
timer0When atomic.Int64 timer0When atomic.Int64