From 1aa191b468f0dde2546c8430dbfffb8b94e7568b Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Wed, 30 Nov 2016 03:24:40 +0000 Subject: [PATCH] doc: remove some TODOs from go1.8.html TBR=See https://golang.org/cl/33244 Updates #17929 Change-Id: I5d92bd62b6560d245f77fa042c7e35d9eddc4994 Reviewed-on: https://go-review.googlesource.com/33683 Reviewed-by: Brad Fitzpatrick --- doc/go1.8.html | 66 ++++++++++++++++++++++++-------------------------- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/doc/go1.8.html b/doc/go1.8.html index 8021d10ae3..ec65e1ef8e 100644 --- a/doc/go1.8.html +++ b/doc/go1.8.html @@ -237,19 +237,17 @@ internal/trace: fix analysis of EvGoWaiting/EvGoInSyscall events (CL 25572)

Vet

-

TODO:

-
-cmd/vet: accept space-separated tag lists for compatibility with cmd/go (CL 32030)
-cmd/vet: allow ^& uintptr arithmetic (CL 27156)
-cmd/vet: allow any printf verb with any interface (CL 27127)
-cmd/vet: check for copying of array of locks (CL 24340)
-cmd/vet: check for duplicate json, xml struct field tags (CL 16704)
-cmd/vet: detect defer resp.Body.Close() before error check (CL 32911)
-cmd/vet: diagnose non-space-separated struct tag like `json:"x",xml:"y"` (CL 32031)
-cmd/vet: improve asmdecl parameter handling (CL 27150)
-cmd/vet: properly handle indexed arguments in printf (CL 24391)
-cmd/vet: skip printf check for non-constant format string during failed import (CL 29014)
-
+

Vet is stricter in some ways and looser others which + caused false positives.

+ +

Vet now checks copying of array of locks, + duplicate JSON and XML struct field tags, + non-space-separated struct tags, + deferred calls to HTTP Response.Body.Close + before checking errors, + indexed arguments in Printf, + and improves existing checks.

+

Compiler Toolchain

@@ -660,7 +658,7 @@ Optimizations and bug fixes are not listed.

- The new Config.GetConfigForClient (TODO: make link work) + The new Config.GetConfigForClient callback allows selecting a configuration for a client dynamically, based on the client's ClientHelloInfo. @@ -675,7 +673,7 @@ Optimizations and bug fixes are not listed.

- The new Config.GetClientCertificate (TODO: make link work) + The new Config.GetClientCertificate callback allows selecting a client certificate based on the server's TLS CertificateRequest message, represented by the new CertificateRequestInfo. @@ -684,7 +682,7 @@ Optimizations and bug fixes are not listed.

The new Config.KeyLogWriter - (TODO: make link work) allows debugging TLS connections + allows debugging TLS connections in WireShark and similar tools.

@@ -692,7 +690,6 @@ Optimizations and bug fixes are not listed.

The new Config.VerifyPeerCertificate - (TODO: make link work) callback allows additional validation of a peer's presented certificate.

@@ -825,17 +822,18 @@ crypto/x509: return error for missing SerialNumber (CL 27238)
debug/pe

- TODO: describe Issue 15345 and CL 22181, CL 22332, CL 22336 - 

pkg debug/pe, method (*COFFSymbol) FullName(StringTable) (string, error)
-pkg debug/pe, method (StringTable) String(uint32) (string, error)
-pkg debug/pe, type File struct, COFFSymbols []COFFSymbol
-pkg debug/pe, type File struct, StringTable StringTable
-pkg debug/pe, type Reloc struct
-pkg debug/pe, type Reloc struct, SymbolTableIndex uint32
-pkg debug/pe, type Reloc struct, Type uint16
-pkg debug/pe, type Reloc struct, VirtualAddress uint32
-pkg debug/pe, type Section struct, Relocs []Reloc
-pkg debug/pe, type StringTable []uint8
+ The package has been fleshed out and is now used by the Go linker. + New are + Reloc, + Section, + StringTable, + the method + COFFSymbol.FullName, + and + File + fields + COFFSymbols and + StringTable.

@@ -1050,7 +1048,9 @@ pkg debug/pe, type StringTable []uint8 depend on implementations obeying the documentation.

Updating: implementations of the Conn interface should verify - they implement the documented semantics. TODO: https://golang.org/cl/18097 + they implement the documented semantics. The + golang.org/x/net/nettest + package will exercise a Conn and validate it behaves properly.

@@ -1164,11 +1164,9 @@ pkg debug/pe, type StringTable []uint8