qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 08:38:01 -07:00
Code Releases Activity

cmd/compile: remove typechecker calls in varDecl()

Browse Source 
We can now use transformAssign.

The only remaining typechecker calls in the noder2 pass are for
CompLitExpr nodes (OCOMPLIT).

Change-Id: I25671c79cc30749767bb16f84e9f151b943eccd1
Reviewed-on: https://go-review.googlesource.com/c/go/+/305509
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Trust: Dan Scales <danscales@google.com>
This commit is contained in:
Dan Scales 2021-03-25 12:23:44 -07:00
parent 2abf280a28
commit 1a7d921aa5
3 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/cmd/compile/internal/noder/decl.go
View File

@ -211,11 +211,24 @@ func (g *irgen) varDecl(out *ir.Nodes, decl *syntax.VarDecl) {
} else if ir.CurFunc == nil {
name.Defn = as
}
out.Append(typecheck.Stmt(as))
lhs := []ir.Node{as.X}
rhs := []ir.Node{}
if as.Y != nil {
rhs = []ir.Node{as.Y}
}
transformAssign(as, lhs, rhs)
as.X = lhs[0]
if as.Y != nil {
as.Y = rhs[0]
}
as.SetTypecheck(1)
out.Append(as)
}
}
if as2 != nil {
out.Append(typecheck.Stmt(as2))
transformAssign(as2, as2.Lhs, as2.Rhs)
as2.SetTypecheck(1)
out.Append(as2)
}
}

1
src/cmd/compile/internal/noder/expr.go
View File

@ -15,7 +15,6 @@ import (
)
func (g *irgen) expr(expr syntax.Expr) ir.Node {
// TODO(mdempsky): Change callers to not call on nil?
if expr == nil {
return nil
}

4
src/cmd/compile/internal/noder/helpers.go
View File

@ -18,10 +18,6 @@ import (
//
// TODO(mdempsky): Move into their own package so they can be easily
// reused by iimport and frontend optimizations.
//
// TODO(mdempsky): Update to consistently return already typechecked
// results, rather than leaving the caller responsible for using
// typecheck.Expr or typecheck.Stmt.
type ImplicitNode interface {
ir.Node