qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 20:34:42 -07:00
Code Releases Activity

runtime: fix error check in freebsd/386 i386_set_ldt

Browse Source 
Update #2675

The code here was using the error check for Linux/386,
not the one for FreeBSD/386. Most of the time it worked.

Thanks to Neel Natu (FreeBSD developer) for finding this.

The s/JCC/JAE/ a few lines later is a no-op but makes the
test match the rest of the file. Why we write JAE instead of JCC
I don't know, but the two are equivalent and the file might
as well be consistent.

LGTM=bradfitz, minux
R=golang-codereviews, bradfitz, minux
CC=golang-codereviews
https://golang.org/cl/99680044
This commit is contained in:
Russ Cox 2014-05-31 09:35:37 -04:00
parent a238973949
commit 19c8f67e25
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/pkg/runtime/sys_freebsd_386.s
View File

@ -309,8 +309,7 @@ TEXT runtime·i386_set_ldt(SB),NOSPLIT,$16
MOVL AX, 8(SP) MOVL AX, 8(SP)
MOVL $165, AX MOVL $165, AX
INT $0x80 INT $0x80
CMPL AX, $0xfffff001 JAE 2(PC)
JLS 2(PC)
INT $3 INT $3
RET RET
@ -326,7 +325,7 @@ TEXT runtime·sysctl(SB),NOSPLIT,$28
MOVSL // arg 6 - newlen MOVSL // arg 6 - newlen
MOVL $202, AX // sys___sysctl MOVL $202, AX // sys___sysctl
INT $0x80 INT $0x80
JCC 3(PC) JAE 3(PC)
NEGL AX NEGL AX
RET RET
MOVL $0, AX MOVL $0, AX