From 1977f1cf7df3172b930129929a3ec075da9d2967 Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Tue, 7 Feb 2017 14:22:38 -0500 Subject: [PATCH] go/ssa/interp: remove old TODO Change-Id: Ia518721769048a5f7413eb90265cc27128cc9c10 Reviewed-on: https://go-review.googlesource.com/36537 Reviewed-by: Robert Griesemer --- go/ssa/interp/interp.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/go/ssa/interp/interp.go b/go/ssa/interp/interp.go index bc1bd1b10a2..8d93295f8a6 100644 --- a/go/ssa/interp/interp.go +++ b/go/ssa/interp/interp.go @@ -314,9 +314,7 @@ func visitInstr(fr *frame, instr ssa.Instruction) continuation { fr.env[instr] = fr.get(instr.Iter).(iter).next() case *ssa.FieldAddr: - x := fr.get(instr.X) - // FIXME wrong! &global.f must not change if we do *global = zero! - fr.env[instr] = &(*x.(*value)).(structure)[instr.Field] + fr.env[instr] = &(*fr.get(instr.X).(*value)).(structure)[instr.Field] case *ssa.Field: fr.env[instr] = fr.get(instr.X).(structure)[instr.Field]