From 1807d54d8594c52cdf79c8a9ad60607d2796fec6 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Mon, 27 Jul 2015 12:45:56 -0700 Subject: [PATCH] [dev.ssa] cmd/compile: detect unbalanced rules Rules may span multiple lines, but if we're still unbalanced at the end of the file, something is wrong. I write unbalanced rules depressingly often. Change-Id: Ibd04aa06539e2a0ffef73bb665febf3542fd11f1 Reviewed-on: https://go-review.googlesource.com/12710 Reviewed-by: Keith Randall --- src/cmd/compile/internal/ssa/gen/rulegen.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cmd/compile/internal/ssa/gen/rulegen.go b/src/cmd/compile/internal/ssa/gen/rulegen.go index 46e0e507c4..8dca0bca1f 100644 --- a/src/cmd/compile/internal/ssa/gen/rulegen.go +++ b/src/cmd/compile/internal/ssa/gen/rulegen.go @@ -88,6 +88,9 @@ func genRules(arch arch) { } rule = "" } + if unbalanced(rule) { + log.Fatalf("unbalanced rule: %v\n", rule) + } if err := scanner.Err(); err != nil { log.Fatalf("scanner failed: %v\n", err) }