1
0
mirror of https://github.com/golang/go synced 2024-11-22 02:04:40 -07:00

undo CL 4808044 / 1bd754e69ce7

ServeMux depends on having a URL
in order to mux.  It might be that the right
fix is to have CONNECT handlers just not
look at URL.

««« original CL description
http: do not parse req.URL for CONNECT

CONNECT's argument is not a URL.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4808044

»»»

TBR=bradfitz
CC=golang-dev
https://golang.org/cl/4798046
This commit is contained in:
Russ Cox 2011-07-21 13:25:55 -04:00
parent bf5ec12dd5
commit 17d9093bf2
2 changed files with 3 additions and 30 deletions

View File

@ -152,28 +152,6 @@ var reqTests = []reqTest{
noBody, noBody,
"parse : empty url", "parse : empty url",
}, },
// CONNECT method.
{
"CONNECT proxy.example.com:443 HTTP/1.0\r\n" +
"Host: proxy.example.com\r\n\r\n",
&Request{
Method: "CONNECT",
RawURL: "proxy.example.com:443",
URL: nil,
Proto: "HTTP/1.0",
ProtoMajor: 1,
ProtoMinor: 0,
Close: false,
ContentLength: 0,
Host: "proxy.example.com",
Form: Values{},
},
noBody,
noError,
},
} }
func TestReadRequest(t *testing.T) { func TestReadRequest(t *testing.T) {

View File

@ -548,11 +548,8 @@ func ReadRequest(b *bufio.Reader) (req *Request, err os.Error) {
return nil, &badStringError{"malformed HTTP version", req.Proto} return nil, &badStringError{"malformed HTTP version", req.Proto}
} }
isConnect := strings.ToUpper(req.Method) == "CONNECT" if req.URL, err = ParseRequestURL(req.RawURL); err != nil {
if !isConnect { return nil, err
if req.URL, err = ParseRequestURL(req.RawURL); err != nil {
return nil, err
}
} }
// Subsequent lines: Key: value. // Subsequent lines: Key: value.
@ -569,9 +566,7 @@ func ReadRequest(b *bufio.Reader) (req *Request, err os.Error) {
// GET http://www.google.com/index.html HTTP/1.1 // GET http://www.google.com/index.html HTTP/1.1
// Host: doesntmatter // Host: doesntmatter
// the same. In the second case, any Host line is ignored. // the same. In the second case, any Host line is ignored.
if !isConnect { req.Host = req.URL.Host
req.Host = req.URL.Host
}
if req.Host == "" { if req.Host == "" {
req.Host = req.Header.Get("Host") req.Host = req.Header.Get("Host")
} }