From 163653eeaafad9e7ad9e1cea421f683b62e5904f Mon Sep 17 00:00:00 2001 From: Hyang-Ah Hana Kim Date: Tue, 20 Oct 2015 17:42:21 -0400 Subject: [PATCH] go/build: test code cleanup: remove unnecessary func var The earlier calls to test(false) in TestDependencies were removed by https://golang.org/cl/12576 Change-Id: If5c7994172379c2d7f633d2e9c5261e668c754fa Reviewed-on: https://go-review.googlesource.com/16117 Reviewed-by: Ian Lance Taylor --- src/go/build/deps_test.go | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/src/go/build/deps_test.go b/src/go/build/deps_test.go index 58b93436ee..9746c167ab 100644 --- a/src/go/build/deps_test.go +++ b/src/go/build/deps_test.go @@ -456,26 +456,23 @@ func TestDependencies(t *testing.T) { } sort.Strings(all) - test := func(mustImport bool) { - for _, pkg := range all { - imports, err := findImports(pkg) - if err != nil { - t.Error(err) - continue - } - ok := allowed(pkg) - var bad []string - for _, imp := range imports { - if !ok[imp] { - bad = append(bad, imp) - } - } - if bad != nil { - t.Errorf("unexpected dependency: %s imports %v", pkg, bad) + for _, pkg := range all { + imports, err := findImports(pkg) + if err != nil { + t.Error(err) + continue + } + ok := allowed(pkg) + var bad []string + for _, imp := range imports { + if !ok[imp] { + bad = append(bad, imp) } } + if bad != nil { + t.Errorf("unexpected dependency: %s imports %v", pkg, bad) + } } - test(true) } var buildIgnore = []byte("\n// +build ignore")