1
0
mirror of https://github.com/golang/go synced 2024-11-11 19:31:37 -07:00

misc/ios,runtime/cgo: remove SIGINT handshake for the iOS exec wrapper

Once upon a time, the iOS exec wrapper needed to change the current
working directory for the binary being tested. To allow that, the
runtime raised a SIGINT signal that the wrapper caught, changed the
working directory and resumed the process.

These days, the current working directory is passed from the wrapper
to the runtime through a special entry in the app metadata and the
SIGINT handshake is not necessary anymore.

Remove the signaling from the runtime and the exec harness.

Change-Id: Ia53bcc9e4724d2ca00207e22b91ce80a05271b55
Reviewed-on: https://go-review.googlesource.com/106096
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
This commit is contained in:
Elias Naur 2018-04-10 13:26:05 +02:00
parent 7289607b1b
commit 144fae8ed5
3 changed files with 2 additions and 8 deletions

View File

@ -259,11 +259,9 @@ func run(bin string, args []string) (err error) {
}
started = true
s.doCmd("run", "stop reason = signal SIGINT", 20*time.Second)
startTestsLen := s.out.Len()
fmt.Fprintln(s.in, `process continue`)
s.do("run")
passed := func(out *buf) bool {
// Just to make things fun, lldb sometimes translates \n into \r\n.

View File

@ -140,8 +140,6 @@ init_working_dir()
if (chdir(buf) != 0) {
fprintf(stderr, "runtime/cgo: chdir(%s) failed\n", buf);
}
// Notify the test harness that we're correctly set up
raise(SIGINT);
}
}

View File

@ -142,8 +142,6 @@ init_working_dir()
if (chdir(buf) != 0) {
fprintf(stderr, "runtime/cgo: chdir(%s) failed\n", buf);
}
// Notify the test harness that we're correctly set up
raise(SIGINT);
}
}