qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 22:34:33 -06:00
Code Releases Activity

cmd/compile/internal/types2: adjust errorcalls_test and apply it

Browse Source 
Checker.errorf calls now have an error code and thus require at
least 4 arguments.

Change-Id: Id01c30d5d3cc747ab0b3ba4001e88985192f2d80
Reviewed-on: https://go-review.googlesource.com/c/go/+/441957
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
Robert Griesemer 2022-10-10 13:22:16 -07:00 committed by Gopher Robot
parent 2dbc5736b2
commit 140bc24445
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/cmd/compile/internal/types2/errorcalls_test.go
View File

@ -9,8 +9,10 @@ import (
"testing"
)
// TestErrorCalls makes sure that check.errorf calls have at
// least 3 arguments (otherwise we should be using check.error).
const errorfMinArgCount = 4
// TestErrorCalls makes sure that check.errorf calls have at least
// errorfMinArgCount arguments (otherwise we should use check.error).
func TestErrorCalls(t *testing.T) {
files, err := pkgFiles(".")
if err != nil {
@ -30,11 +32,11 @@ func TestErrorCalls(t *testing.T) {
if !(isName(selx.X, "check") && isName(selx.Sel, "errorf")) {
return false
}
// check.errorf calls should have more than 2 arguments:
// position, format string, and arguments to format
if n := len(call.ArgList); n <= 2 {
t.Errorf("%s: got %d arguments, want > 2", call.Pos(), n)
return true
// check.errorf calls should have at least errorfMinArgCount arguments:
// position, code, format string, and arguments to format
if n := len(call.ArgList); n < errorfMinArgCount {
t.Errorf("%s: got %d arguments, want at least %d", call.Pos(), n, errorfMinArgCount)
return false
}
return false
})