qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-24 13:10:12 -06:00
Code Releases Activity

cmd/compile: only avoid escaping package paths for "go.shape"

Browse Source 
We have code that intends to avoid escaping the package path for
built-in packages. But it is hard to determine which packages are
built-in from a general rule, and we really only want to avoid escaping
for the "go.shape" package (since that gives ugly shape type names). So,
fix the code to only avoid escaping the package path specifically for
the "go.shape" package.

Fixes #50200

Change-Id: Ibaedd7690b99a173007c608c5dfa783ef82b326d
Reviewed-on: https://go-review.googlesource.com/c/go/+/372934
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
This commit is contained in:
Dan Scales 2021-12-16 13:24:40 -08:00
parent b1a53ece68
commit 1387b5e91d
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/cmd/compile/internal/types/pkg.go
View File

@ -9,7 +9,6 @@ import (
"cmd/internal/objabi"
"fmt"
"sort"
"strings"
"sync"
)
@ -49,9 +48,11 @@ func NewPkg(path, name string) *Pkg {
p := new(Pkg)
p.Path = path
p.Name = name
if strings.HasPrefix(path, "go.") && !strings.Contains(path, "/") {
// Special compiler-internal packages don't need to be escaped.
// This particularly helps with the go.shape package.
if path == "go.shape" {
// Don't escape "go.shape", since it's not needed (it's a builtin
// package), and we don't want escape codes showing up in shape type
// names, which also appear in names of function/method
// instantiations.
p.Prefix = path
} else {
p.Prefix = objabi.PathToPrefix(path)