1
0
mirror of https://github.com/golang/go synced 2024-11-12 00:20:22 -07:00

runtime: zeroize g->fnstart to not prevent GC of the closure

Fixes #5493.

R=golang-dev, minux.ma, iant
CC=golang-dev
https://golang.org/cl/9557043
This commit is contained in:
Dmitriy Vyukov 2013-05-20 08:17:21 +04:00
parent d4cbc80d10
commit 1308194204
2 changed files with 53 additions and 0 deletions

View File

@ -1232,6 +1232,7 @@ static void
goexit0(G *gp)
{
gp->status = Gdead;
gp->fnstart = nil;
gp->m = nil;
gp->lockedm = nil;
m->curg = nil;

View File

@ -0,0 +1,52 @@
// run
// Copyright 2013 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
import (
"runtime"
"sync"
"sync/atomic"
"time"
)
const N = 10
var count int64
func run() error {
f1 := func() {}
f2 := func() {
func() {
f1()
}()
}
runtime.SetFinalizer(&f1, func(f *func()) {
atomic.AddInt64(&count, -1)
})
go f2()
return nil
}
func main() {
count = N
var wg sync.WaitGroup
wg.Add(N)
for i := 0; i < N; i++ {
go func() {
run()
wg.Done()
}()
}
wg.Wait()
for i := 0; i < 2*N; i++ {
time.Sleep(10 * time.Millisecond)
runtime.GC()
}
if count != 0 {
panic("not all finalizers are called")
}
}