From 12febf440ab165c4216be22da05880e7fd2e968f Mon Sep 17 00:00:00 2001 From: Edward Muller Date: Fri, 6 Sep 2019 20:32:09 +0000 Subject: [PATCH] internal/lsp/cache: detail why the err is ignored As per slack discussion with Rebecca Stambler. https://gophers.slack.com/archives/CJZH85XCZ/p1560289227072200 Change-Id: Iaa0f93045edd719e1a874ff6ad9bc8d9e51543d5 Change-Id: Iaa0f93045edd719e1a874ff6ad9bc8d9e51543d5 GitHub-Last-Rev: b54997de95b10d01efe4722a28aea376795ba83f GitHub-Pull-Request: golang/tools#115 Reviewed-on: https://go-review.googlesource.com/c/tools/+/181778 Reviewed-by: Rebecca Stambler Run-TryBot: Rebecca Stambler TryBot-Result: Gobot Gobot --- internal/lsp/cache/check.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/lsp/cache/check.go b/internal/lsp/cache/check.go index c494fbc573..558836d3db 100644 --- a/internal/lsp/cache/check.go +++ b/internal/lsp/cache/check.go @@ -292,8 +292,8 @@ func (imp *importer) typeCheck(ctx context.Context, cph *checkPackageHandle, m * } check := types.NewChecker(cfg, imp.view.session.cache.FileSet(), pkg.types, pkg.typesInfo) - // Ignore type-checking errors. - check.Files(files) + // Type checking errors are handled via the config, so ignore them here. + _ = check.Files(files) return pkg, nil }